Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always infer gossip DNS from cluster name #14366

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Always infer gossip DNS from cluster name #14366

merged 1 commit into from
Oct 2, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 2, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/api area/nodeup area/provider/aws Issues or PRs related to aws provider labels Oct 2, 2022
@hakman
Copy link
Member Author

hakman commented Oct 2, 2022

/test pull-kops-e2e-kubernetes-do-gossip

@kubernetes kubernetes deleted a comment from k8s-ci-robot Oct 2, 2022
@hakman hakman force-pushed the gossip_from_cluster_name branch 2 times, most recently from a645bb9 to 3a1ab90 Compare October 2, 2022 09:39
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2022
@hakman hakman changed the title Infer gossip DNS from cluster name Always infer gossip DNS from cluster name Oct 2, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider labels Oct 2, 2022
@hakman hakman force-pushed the gossip_from_cluster_name branch 2 times, most recently from df8c37c to 8c6b7c2 Compare October 2, 2022 09:51
@hakman
Copy link
Member Author

hakman commented Oct 2, 2022

/test pull-kops-e2e-kubernetes-do-gossip

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit af1f6d0 into kubernetes:master Oct 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 2, 2022
@hakman hakman deleted the gossip_from_cluster_name branch October 2, 2022 11:58
@rifelpet
Copy link
Member

rifelpet commented Oct 4, 2022

@hakman I think this is causing some e2e failures:

https://testgrid.k8s.io/kops-misc#kops-aws-external-dns

https://testgrid.k8s.io/kops-misc#e2e-kops-do-calico-fqdn

@hakman hakman mentioned this pull request Oct 4, 2022
Merged
@hakman
Copy link
Member Author

hakman commented Oct 4, 2022

Thanks @rifelpet. Looks like #14377 fixed the issue: https://testgrid.k8s.io/kops-misc#kops-aws-external-dns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @rifelpet @olemarkus