Automated cherry pick of #14370: get-keypairs: Tolerate items without certificates #14427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the "kops get keypairs" command to consume key sets with old key pair items that lack an associated X.509 certificate. When the command is invoked without the "--distrusted" flag set to true, omit these old items as if they're distrusted. Conversely, when the command is invoked with the "--distrusted" flag set to true, include these items, but omit their details that would be contingent on the nonexistent certificate. In order to supply only information that is known to be true, treat the following fields in the output as newly optional: - issuer - notAfter - notBefore - subject With no certificate present, it's not possible to present concrete values for those fields.
Forbid the "kops promote keypair" command from promoting a key pair item that lacks an associated X.509 certificate. Along with that prohibition, refuse to store a key set in a VFS whose primary key pair lacks a certificate. This allows us to continue storing such key pairs, but we will never allow them to serve as the primary key pair within the containing key set.
k8s-ci-robot
added
cncf-cla: yes
johngmyers
approved these changes
Oct 18, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
deleted the
automated-cherry-pick-of-#14370-upstream-release-1.25
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #14370 on release-1.25.
#14370: get-keypairs: Tolerate items without certificates
For details on the cherry pick process, see the cherry pick requests page.