-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add best practices to getting started with GCE docs #14569
Add best practices to getting started with GCE docs #14569
Conversation
Welcome @danielvegamyhre! |
Hi @danielvegamyhre. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @danielvegamyhre! :) |
Awesome, thank you @danielvegamyhre I like the idea of guiding users a bit more as to "things they should be doing", in addition to describing all the things they can do! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
I'll have a look at why these tests are suddenly failing, it's surprising and I can't see how it could relate to a docs PR :-) |
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
@justinsb We noticed something similar on other PRs. Somehow it seems like rebase doesn't work well. Manual rebase helped, but didn't have time look deeper to see why it happens. |
@danielvegamyhre: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The problem looks to be this from kubelet:
I think the issue is that we build from source, but then when we upload we might not run with the matching nodeup, because we don't always upload it:
We should fix this, but probably not in this PR. I'm going to merge this one manually. |
The kubeconfig has an empty server. Using a locally built nodeup binary, I don't see this issue. Rebasing a PR would also fix the issue. |
The purpose of these changes is to document some best practices when using kOps to create and administer a k8s cluster in GCP. For each best practice, I included a description of why it is considered a best practice, as well as example kops commands to utilize it.
Currently the best practices I have included are:
I tested these changes using
make live-docs
to view my changes locally.Let me know if there are additional best practices we should add and I will be happy to do so.