Use NodeupConfig for container-runtime configuration #14936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/api
area/nodeup
size/XXL
johngmyers
force-pushed
the
nodeup-runtime
branch
from
cad26dd
to
e44ce84
Compare
johngmyers
changed the title
hakman
reviewed
Jan 3, 2023
Comment on lines
+75
to
+78
| // ContainerdConfig holds the configuration for containerd. | ||
| ContainerdConfig *kops.ContainerdConfig `json:"containerdConfig,omitempty"` | ||
| // Docker holds the configuration for docker. | ||
| Docker *kops.DockerConfig `json:"docker,omitempty"` |
There was a problem hiding this comment.
Not quite sure about ContainerdConfig vs Docker or DockerConfig.
hakman
approved these changes
Jan 3, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.