Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nvidia container toolkit repos #15096

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Fix nvidia container toolkit repos #15096

merged 3 commits into from
Feb 3, 2023

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Feb 2, 2023

This PR updates the repositories and the installation of the NVIDIA Container Toolkit.

This ensures that #15094 is less likely to occur in future.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @elezar!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @elezar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 2, 2023
@elezar
Use ubuntu18.04 repos for nvidia-container-toolkit
1f0b2eb 
The ubuntu20.04 and ubunut22.04 repositories are "mirrors" of the
ubuntu18.04 repository. This change ensures that the ubuntu18.04 repository
is used regardless of the Ubuntu distribution.

Signed-off-by: Evan Lezar <evanlezar@gmail.com>
@elezar
Use gpgkey from libnvidia-container repository
cf066cf 
The same gpgkey is served from both the nvidia-container-runtime and
libnvidia-container repos.

Signed-off-by: Evan Lezar <evanlezar@gmail.com>
@elezar
Install nvidia-container-toolkit as top-level package
02adbc7 
As of the NVIDIA Container Toolkit v1.6.0 release the nvidia-container-toolkit
is the top-level package for installing the NVIDIA container stack with the
nvidia-container-runtime provided as a meta-package to support "legacy"
workflows such as this.

This change installs the nvidia-container-toolkit package directly instead.

Note that the nvidia-container-runtime binary is included in this package.

See https://github.com/NVIDIA/nvidia-container-toolkit/releases/tag/v1.6.0

Signed-off-by: Evan Lezar <evanlezar@gmail.com>
@elezar elezar force-pushed the fix-nvidia-container-toolkit-repos branch from 93d559f to 02adbc7 Compare February 2, 2023 13:47
@elezar elezar mentioned this pull request Feb 2, 2023
Closed
@hakman
Copy link
Member

hakman commented Feb 2, 2023

Thanks @elezar. Much appreciated!
/lgtm
/assign @olemarkus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@hakman
Copy link
Member

hakman commented Feb 2, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2023
zetaab
zetaab requested changes Feb 2, 2023
View reviewed changes
nodeup/pkg/model/nvidia.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
olemarkus
olemarkus approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix this.

nodeup/pkg/model/nvidia.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2023
@zetaab
Copy link
Member

zetaab commented Feb 3, 2023 •
edited
Loading

@elezar do you want to do cherry pick of this PR to release-1.26 + release-1.25 as well? Its broken there as well

@hakman
Copy link
Member

hakman commented Feb 3, 2023

@zetaab Probably easier if you do it. I can approve those PRs.

This was referenced Feb 3, 2023
Merged
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ffdffb3 into kubernetes:master Feb 3, 2023
k8s-ci-robot added a commit that referenced this pull request Feb 3, 2023
@k8s-ci-robot
Merge pull request #15100 from zetaab/automated-cherry-pick-of-#15096…
edbbac1 
…-upstream-release-1.26

Automated cherry pick of #15096: Use ubuntu18.04 repos for nvidia-container-toolkit
k8s-ci-robot added a commit that referenced this pull request Feb 3, 2023
@k8s-ci-robot
Merge pull request #15101 from zetaab/automated-cherry-pick-of-#15096…
60e4858 
…-upstream-release-1.25

Automated cherry pick of #15096: Use ubuntu18.04 repos for nvidia-container-toolkit
@elezar elezar deleted the fix-nvidia-container-toolkit-repos branch February 3, 2023 12:59
@elezar
Copy link
Contributor Author

elezar commented Feb 3, 2023

Thanks for the quick turnaround on this!

Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
@k8s-ci-robot
Merge pull request kubernetes#15100 from zetaab/automated-cherry-pick…
bf9ed28 
…-of-#15096-upstream-release-1.26

Automated cherry pick of kubernetes#15096: Use ubuntu18.04 repos for nvidia-container-toolkit
@elezar elezar mentioned this pull request Sep 21, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@zetaab zetaab zetaab approved these changes

@hakman hakman Awaiting requested review from hakman

Assignees

@olemarkus olemarkus

@hakman hakman

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elezar @k8s-ci-robot @hakman @zetaab @olemarkus