Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-router to v1.5.3 #15270

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

chenliu1993
Copy link
Contributor

Update kube-router to v1.5.3

Tried in aws provider using kops ans other components built based on master and it worked as it was in v1.2.3

Signed-off-by: chenliu1993 <cl2037829916@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @chenliu1993!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @chenliu1993. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2023
@hakman
Copy link
Member

hakman commented Mar 26, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2023
@chenliu1993
Copy link
Contributor Author

/retest

@chenliu1993
Copy link
Contributor Author

chenliu1993 commented Mar 27, 2023

hi @hakman , I am trying to understand the process from promoting the kube-router version to stable channel and do a version-up. May I know what should be done to make sure the kube-router is ok to put in release? I notice that there is some tests trigger by pull lies in test-infra?

@hakman
Copy link
Member

hakman commented Mar 27, 2023

Thanks @chenliu1993.
It looks good now that pull-kops-e2e-cni-kuberouter is passing. Generally, there are other changes to the manifest, but there were no changes to any of the files in https://github.com/cloudnativelabs/kube-router/tree/master/daemonset for the last 3 years. Maybe once 2.0.0 will be out, there will be something more to change.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 251d78d into kubernetes:master Mar 27, 2023
@chenliu1993
Copy link
Contributor Author

chenliu1993 commented Mar 27, 2023

Thanks @chenliu1993. It looks good now that pull-kops-e2e-cni-kuberouter is passing. Generally, there are other changes to the manifest, but there were no changes to any of the files in https://github.com/cloudnativelabs/kube-router/tree/master/daemonset for the last 3 years. Maybe once 2.0.0 will be out, there will be something more to change. /lgtm /approve

Thank you @hakman for the information!
And I also noticed that a issue is looking for kube-router manintainer, if no one is taking this and you are still finding, I'd like to help 😊

k8s-ci-robot added a commit that referenced this pull request Apr 3, 2023
…-upstream-release-1.26

Automated cherry pick of #15270: Update kube-router to v1.5.3
Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
…-of-#15270-upstream-release-1.26

Automated cherry pick of kubernetes#15270: Update kube-router to v1.5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants