Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 Terraform code generation #15275

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Fix IPv6 Terraform code generation #15275

merged 2 commits into from
Apr 13, 2023

Conversation

felixfriedrich
Copy link
Contributor

@felixfriedrich felixfriedrich commented Mar 28, 2023 •
edited
Loading

This PR fixes #15245

LiteralEqualConditionExpression is a bit more generic than necessary. I couldn't find a good name for a function, which would do an equal comparison to empty String, but would return null in that case.
Creating a function, which would generically do a equal comparison felt more natural. Also, the return values are now explicit at the place of calling.

Happy to change this in case there are any concerns.

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Mar 28, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 28, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Hi @felixfriedrich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2023
@hakman hakman changed the title Fix IPv6 Terraform code generation issue #15274 Fix IPv6 Terraform code generation Mar 28, 2023
@hakman
Copy link
Member

hakman commented Mar 28, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2023
@felixfriedrich
Copy link
Contributor Author

@hakman All GitHub Actions that ran succeeded. What else needs to be done in terms of testing? What's the next step to get this merged?

@felixfriedrich
Copy link
Contributor Author

felixfriedrich commented Apr 12, 2023 •
edited
Loading

@johngmyers I am replacing a function you wrote. Would you have a look at my change? It fixes the issue linked to in the description.

hakman
hakman approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixfriedrich! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 102f0e6 into kubernetes:master Apr 13, 2023
@hakman hakman mentioned this pull request Apr 13, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 13, 2023
@k8s-ci-robot
Merge pull request #15309 from hakman/automated-cherry-pick-of-#15275…
43ecbdc 
…-upstream-release-1.26

Automated cherry pick of #15275: AWS: Check if vpc_ipv6_cidr_block is an empty string
Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
@k8s-ci-robot
Merge pull request kubernetes#15309 from hakman/automated-cherry-pick…
5619a5f 
…-of-#15275-upstream-release-1.26

Automated cherry pick of kubernetes#15275: AWS: Check if vpc_ipv6_cidr_block is an empty string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated Terraform code related to vpc_ipv6_cidr_block fails
3 participants
@felixfriedrich @k8s-ci-robot @hakman