Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Use interface attach when reconciling server ports #15299

Merged
merged 2 commits into from
May 23, 2023
Merged

OpenStack: Use interface attach when reconciling server ports #15299

merged 2 commits into from
May 23, 2023

Conversation

ederst
Copy link
Contributor

@ederst ederst commented Apr 6, 2023

This makes use of the interface attach method when reconciling server ports.

The difference between just setting the DeviceID on the Port and this is that with the attachment process the server is also validated. Which means for example that a Port cannot be attached to a server in ERROR
state.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ederst. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ederst ederst changed the title OpenStack: OpenStack: Use interface attach when reconciling server ports Apr 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from hakman April 6, 2023 20:02
@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zetaab April 6, 2023 20:02
@ederst ederst changed the title OpenStack: Use interface attach when reconciling server ports WIP OpenStack: Use interface attach when reconciling server ports Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@ederst ederst changed the title WIP OpenStack: Use interface attach when reconciling server ports OpenStack: Use interface attach when reconciling server ports May 22, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2023
@ederst
Copy link
Contributor Author

ederst commented May 23, 2023

@zetaab can you have a look at this too please?

zetaab
zetaab approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@zetaab
Copy link
Member

zetaab commented May 23, 2023

@ederst run make gomod

@hakman
Copy link
Member

hakman commented May 23, 2023

@ederst run make gomod

Maybe also rebase.

@ederst
OpenStack: Use interface attach when reconciling server ports
76c932d 
This makes use of the interface attach method when reconciling server
ports.

The difference between just setting the `DeviceID` on the Port and this
is that with the attachment process the server is also validated. Which
means for example that a Port cannot be attached to a server in `ERROR`
state.
@ederst
Run make gomod
6695881
@ederst ederst force-pushed the os-use-server-interface-attach branch from 8e6dab3 to 6695881 Compare May 23, 2023 19:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@ederst
Copy link
Contributor Author

ederst commented May 23, 2023

@ederst run make gomod

Maybe also rebase.

@hakman @zetaab whynotboth.gif :)

Rebased and ran make gomod with up-to-date go, should do it.

@zetaab
Copy link
Member

zetaab commented May 23, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@ederst
Copy link
Contributor Author

ederst commented May 23, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 80129ab into kubernetes:master May 23, 2023
@ederst ederst deleted the os-use-server-interface-attach branch May 24, 2023 07:13
Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
@k8s-ci-robot
Merge pull request kubernetes#15299 from infonova/os-use-server-inter…
105fd90 
…face-attach

OpenStack: Use interface attach when reconciling server ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@hakman hakman Awaiting requested review from hakman

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ederst @k8s-ci-robot @zetaab @hakman