Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runc to v1.1.7 #15322

Closed
wants to merge 2 commits into from
Closed

Update runc to v1.1.7 #15322

wants to merge 2 commits into from

Conversation

anthonyhaussman
Copy link
Contributor

@anthonyhaussman anthonyhaussman commented Apr 16, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @anthonyhaussman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 16, 2023
@anthonyhaussman anthonyhaussman marked this pull request as ready for review April 16, 2023 18:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zetaab April 16, 2023 18:14
@hakman
Copy link
Member

hakman commented Apr 16, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2023
@hakman
Copy link
Member

hakman commented Apr 16, 2023

/retest

@hakman hakman mentioned this pull request Apr 19, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2023
@hakman
Copy link
Member

hakman commented Apr 19, 2023

/retest

1 similar comment
@hakman
Copy link
Member

hakman commented Apr 19, 2023

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Apr 19, 2023

/retest

@hakman
Copy link
Member

hakman commented Apr 19, 2023

/test pull-kops-e2e-k8s-gce-cilium

@hakman
Copy link
Member

hakman commented Apr 20, 2023

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2023
@kubernetes kubernetes deleted a comment from k8s-triage-robot Apr 26, 2023
@kubernetes kubernetes deleted a comment from k8s-triage-robot Apr 26, 2023
@kubernetes kubernetes deleted a comment from k8s-triage-robot Apr 26, 2023
@hakman
Copy link
Member

hakman commented Apr 26, 2023

/test all

@hakman
Copy link
Member

hakman commented Apr 26, 2023

@anthonyhaussman not quite sure why all these tests are failing. Seems they pass just fine in other PRs.

@hakman
Copy link
Member

hakman commented Apr 27, 2023

@anthonyhaussman Could you try with https://github.com/opencontainers/runc/releases/tag/v1.1.7?

@anthonyhaussman anthonyhaussman changed the title Update runc to v1.1.6 Update runc to v1.1.7 Apr 27, 2023
@hakman
Copy link
Member

hakman commented Apr 27, 2023

/test pull-kops-verify-hashes

@hakman
Copy link
Member

hakman commented Apr 27, 2023

/test pull-kops-e2e-k8s-gce-ipalias

@hakman
Copy link
Member

hakman commented Apr 28, 2023

/test pull-kops-e2e-aws-external-dns

@anthonyhaussman anthonyhaussman force-pushed the feat/kops/runc-v1.1.6 branch from dab753d to 3213602 Compare May 2, 2023 08:05
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023
@anthonyhaussman anthonyhaussman force-pushed the feat/kops/runc-v1.1.6 branch from 3213602 to 923c3d2 Compare May 3, 2023 06:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023
@hakman
Copy link
Member

hakman commented May 3, 2023

/test pull-kops-e2e-aws-external-dns

@hakman
Copy link
Member

hakman commented May 3, 2023

/test pull-kops-aws-distro-ubuntu2204

@k8s-ci-robot
Copy link
Contributor

@anthonyhaussman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-kuberouter 923c3d2 link false /test pull-kops-e2e-cni-kuberouter
pull-kops-e2e-k8s-gce-ipalias 923c3d2 link true /test pull-kops-e2e-k8s-gce-ipalias
pull-kops-e2e-k8s-gce-cilium 923c3d2 link true /test pull-kops-e2e-k8s-gce-cilium

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented May 3, 2023

OK, this makes it easier. Seems the only failure is the GCE tests. On AWS, both AMD64 and ARM64 work as expected.

@hakman hakman mentioned this pull request May 3, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented May 12, 2023

Closing in favor of #15375.

@hakman hakman closed this May 12, 2023
@anthonyhaussman anthonyhaussman deleted the feat/kops/runc-v1.1.6 branch June 8, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anthonyhaussman @k8s-ci-robot @hakman @k8s-triage-robot