Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack Octavia FlavorID #15414

Merged
merged 3 commits into from
May 13, 2023
Merged

OpenStack Octavia FlavorID #15414

merged 3 commits into from
May 13, 2023

Conversation

sn4psh0t
Copy link
Contributor

Support for OpenStack Octavia FlavorID parameter

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sn4psh0t / name: Aurelio Forese (efd50d0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @sn4psh0t!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sn4psh0t. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from hakman May 12, 2023 13:27
@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label May 12, 2023
@sn4psh0t sn4psh0t force-pushed the openstack-octavia-flavorid branch from d2d6042 to 4ed6e6b Compare May 13, 2023 08:02
@sn4psh0t sn4psh0t force-pushed the openstack-octavia-flavorid branch from 4ed6e6b to 908c955 Compare May 13, 2023 08:15
@sn4psh0t
OpenStack Octavia LoadBalancer supports for FlavorID
efd50d0 
When using Octavia as OpenStack Load Balancer, it is now possible to
specify the Octavia flavor ID to use.
@sn4psh0t sn4psh0t force-pushed the openstack-octavia-flavorid branch from 908c955 to efd50d0 Compare May 13, 2023 08:18
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2023
@hakman
Copy link
Member

hakman commented May 13, 2023

/ok-to-test
/cc @zetaab
/assign @zetaab

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zetaab May 13, 2023 08:25
@zetaab
Copy link
Member

zetaab commented May 13, 2023 •
edited
Loading

@sn4psh0t could you run ./hack/update-expected.sh and commit changes to separate commit

@sn4psh0t
OpenStack model servergroup tests with loadbalancer update-expected
6de63e3 
Files changed after running './hack/update-expected.sh'
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2023
zetaab
zetaab requested changes May 13, 2023
View reviewed changes
upup/pkg/fi/cloudup/openstack/cloud.go Outdated
@@ -496,6 +497,9 @@ func buildLoadBalancerClient(c *openstackCloud, spec *kops.OpenstackSpec, provid
return fmt.Errorf("error building lb client: %w", err)
}
lbClient = client
if spec.Loadbalancer.FlavorID != nil {
Copy link
Member

@zetaab zetaab May 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm is these 3 rows really needed? I do not see where c.flavorID is used? imo these changes to this file could be just removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zetaab you're right: openstackCloud struct should not be influenced here, sorry for the oversight. Can I push another commit reverting the changes to cloud.go back?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make new commit to remove that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @zetaab

zetaab
zetaab approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2023
@zetaab
Copy link
Member

zetaab commented May 13, 2023

/test pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot k8s-ci-robot merged commit 0240ad9 into kubernetes:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sn4psh0t @k8s-ci-robot @hakman @zetaab