Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaleway: none DNS option available #15422

Merged
merged 1 commit into from
May 24, 2023
Merged

scaleway: none DNS option available #15422

merged 1 commit into from
May 24, 2023

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented May 16, 2023 •
edited
Loading

This PR adds the possibility for Scaleway clusters to use no DNS.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api labels May 16, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Mia-Cross. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented May 16, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2023
@hakman
Copy link
Member

hakman commented May 16, 2023

/cc

@k8s-ci-robot k8s-ci-robot requested a review from hakman May 16, 2023 19:24
@Mia-Cross Mia-Cross marked this pull request as ready for review May 17, 2023 08:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2023
@hakman
Copy link
Member

hakman commented May 17, 2023

@Mia-Cross Could you check #15367? I am not sure if you added the security improvements, similarly to DO and Hetzner.

@justinsb
Copy link
Member

I do think it's OK to merge this as-is, but yes if we can have the callback-check on scaleway also that would be a great bonus!

@hakman
Copy link
Member

hakman commented May 19, 2023

@Mia-Cross I don't mind either way, so your choice if you want to add now or later.

hakman
hakman approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and iterate. Thanks @Mia-Cross!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit f7d97db into kubernetes:master May 24, 2023
@Mia-Cross Mia-Cross deleted the scw_none_dns branch May 26, 2023 12:15
@Mia-Cross Mia-Cross mentioned this pull request Jun 6, 2023
Closed
Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
@k8s-ci-robot
Merge pull request kubernetes#15422 from scaleway/scw_none_dns
da10f52 
scaleway: none DNS option available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mia-Cross @k8s-ci-robot @hakman @justinsb