-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cilium to v1.12.10 #15449
Update Cilium to v1.12.10 #15449
Conversation
a732be4
to
23ab486
Compare
/cc @aojea |
+1 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if k8sVersion.Minor >= 22 { | ||
// ref: | ||
// https://github.com/kubernetes/kubernetes/issues/96717 | ||
// https://github.com/cilium/cilium/issues/5719 | ||
skipRegex += "|should.create.a.Pod.with.SCTP.HostPort" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hakman it looks like this still needs to be skipped for cilium-eni jobs:
https://testgrid.k8s.io/kops-grid#kops-grid-cilium-eni-u2004-k24-ko26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCTP went GA in 1.20 in kubernetes FEATURE STATE: Kubernetes v1.20 [stable]
, but cilium basic support seems that was added in 1.13 cilium/cilium#20033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aojea
Update Cilium to v1.12.10
No description provided.