Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cert-manager addon to v1.12.1 (latest release) #15450

Merged
merged 2 commits into from
May 26, 2023

Conversation

moshevayner
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
Vendored manifest from the official release
Made sure to change back every namespace ref from cert-manager to kube-system to maintain the current structure. Also re-added all the specific logic for nodeAffinity and tolerations, and some of the templated variables that were previously there.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zetaab May 25, 2023 19:13
@moshevayner
Copy link
Member Author

Hey @olemarkus ! (Sorry for the direct ping) - I noticed that you were the last one to bump this add-on's version, so I wanted to make sure I did that correctly (it's my first time with cert-manager).
I'd appreciate a review if you might have a few mins to look over it.

Thanks! 😄

@moshevayner
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@olemarkus
Copy link
Member

Thanks for this! Looks good.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit bf01e49 into kubernetes:master May 26, 2023
@moshevayner moshevayner deleted the cert-manager-1.12.1 branch May 26, 2023 05:11
Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
Bump cert-manager addon to v1.12.1 (latest release)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants