Use Ubuntu 22.04 (Jammy) as the default distro for K8s 1.27+ #15475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/channels
size/S
hakman
force-pushed
the
default_ubuntu_jammy
branch
from
514bc52
to
aaf7588
Compare
k8s-ci-robot
added
area/documentation
size/XXL
hakman
force-pushed
the
default_ubuntu_jammy
branch
from
8d88efe
to
53a9be0
Compare
|
/retest |
|
/hold for more reviews |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
justinsb
reviewed
Jun 11, 2023
| return defaultHetznerImage, nil | ||
| case api.CloudProviderScaleway: | ||
| return defaultScalewayImage, nil | ||
| if kubernetesVersion.LT(semver.MustParse("1.27.0")) { |
There was a problem hiding this comment.
Something for discussion / another PR, but maybe we should just embed a version of the channel. As it looks like what we're doing is having a fallback where we encode the channel in code, but now we have to keep them in sync.
|
This lgtm! /approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Shimiazoulai
pushed a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jul 13, 2023
Use Ubuntu 22.04 (Jammy) as the default distro for K8s 1.27+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.