Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Karpenter to v0.28.1 #15585

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Update Karpenter to v0.28.1 #15585

merged 3 commits into from
Jul 5, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 3, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/addons labels Jul 3, 2023
@hakman hakman mentioned this pull request Jul 3, 2023
Merged
@kubernetes kubernetes deleted a comment from k8s-ci-robot Jul 3, 2023
anthonyhaussman
anthonyhaussman reviewed Jul 3, 2023
View reviewed changes
upup/models/cloudup/resources/addons/karpenter.sh/k8s-1.19.yaml.template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems aws.nodeNameConvention is no more necessary in the karpenter-global-settings ConfigMap due to aws/karpenter-provider-aws#3851 / aws/karpenter-provider-aws#3408.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hakman hakman changed the title Update Karpenter to v0.28.1 WIP Update Karpenter to v0.28.1 Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@hakman hakman changed the title WIP Update Karpenter to v0.28.1 Update Karpenter to v0.28.1 Jul 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2023
anthonyhaussman
anthonyhaussman reviewed Jul 4, 2023
View reviewed changes
upup/models/cloudup/resources/addons/karpenter.sh/k8s-1.19.yaml.template
Comment on lines -671 to +1132
"encoding": "json",
"encoding": "console",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use json encoding which is more standard for logs management?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes logs very annoying to read and everything else is plain text. No preference here though. @olemarkus any thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a karpenter.logFormat variable with console by default.
I can add it after you merge this PR if you agree. 🙂

Copy link
Member Author

@hakman hakman Jul 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that would be nice. Thanks!
If you want, you can just add it now. Should not affect things here.

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

4 similar comments
@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/test pull-kops-e2e-aws-upgrade-k126-ko126-to-k127-kolatest-karpenter

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@hakman hakman mentioned this pull request Jul 5, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/retest

1 similar comment
@hakman
Copy link
Member Author

hakman commented Jul 5, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7982c6d into kubernetes:master Jul 5, 2023
k8s-ci-robot added a commit that referenced this pull request Jul 5, 2023
@k8s-ci-robot
Merge pull request #15592 from hakman/automated-cherry-pick-of-#15585…
6986f83 
…-upstream-release-1.27

Automated cherry pick of #15585: Update Karpenter to v0.28.1
@anthonyhaussman anthonyhaussman mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyhaussman anthonyhaussman anthonyhaussman left review comments

@olemarkus olemarkus olemarkus approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @olemarkus @anthonyhaussman