Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale config changes for scale prow job on AWS #15599

Merged
merged 11 commits into from
Aug 27, 2023
Merged

Scale config changes for scale prow job on AWS #15599

merged 11 commits into from
Aug 27, 2023

Conversation

prateekgogia
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @prateekgogia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot
Copy link
Contributor

@prateekgogia: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman hakman changed the title [Don't merge] temp change for prow tests WIP temp change for prow tests Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@hakman
Copy link
Member

hakman commented Jul 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2023
@hakman
Copy link
Member

hakman commented Jul 7, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

1 similar comment
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@johngmyers johngmyers removed their request for review July 8, 2023 02:45
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

2 similar comments
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jul 11, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jul 11, 2023

@prateekgogia Seems that eu-central-1 is better for running the test:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/15599/presubmit-kops-aws-scale-amazonvpc-using-cl2/1678576342553071616

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Aug 3, 2023

@prateekgogia Please see my previous comment. It would reduce some of the current flakes.

@prateekgogia
Copy link
Contributor Author

@hakman Thanks yeah will update the region, I wanted to run this to make sure nothing was broken in terms of config. Ran into this error The pod could not start because it could not mount the volume "aws-cred": secret "aws-credentials-boskos-scale-001-kops" not found

@hakman
Copy link
Member

hakman commented Aug 3, 2023

/cc @justinsb @ameukam See ^^^.

@ameukam
Copy link
Member

ameukam commented Aug 3, 2023

Currently presubmit-kops-aws-scale-amazonvpc-using-cl2 running inside the cluster default instead of cluster eks-prow-build-cluster where the secrets are located.

@k8s-ci-robot
Copy link
Contributor

@r0b2g1t: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

2 similar comments
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2023
@prateekgogia prateekgogia changed the title WIP temp change for prow tests Scale config changes for scale prow job on AWS Aug 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman hakman added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed area/documentation area/nodeup area/api area/provider/aws Issues or PRs related to aws provider area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider area/channels area/addons labels Aug 26, 2023
@hakman
Copy link
Member

hakman commented Aug 26, 2023

@prateekgogia Can you squash the commits please? The failed scale test prevents the merge.

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

4 similar comments
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Aug 27, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Aug 27, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, r0b2g1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8c0af05 into kubernetes:master Aug 27, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@r0b2g1t r0b2g1t r0b2g1t approved these changes

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@prateekgogia @k8s-ci-robot @hakman @ameukam @dims @r0b2g1t