Refactor out references to global vfs.Context #15640
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
1 similar comment
|
/retest |
|
/cc @justinsb |
| @@ -51,7 +51,7 @@ import ( | |||
|
|
|||
| type Server struct { | |||
| opt *config.Options | |||
| certNames sets.String | |||
| certNames sets.Set[string] | |||
There was a problem hiding this comment.
FYI the thing to be wary of is that this can make it hard to backport (if we need to backport past the apimachinery version that introduced Set[T]), but this should be fine at this point.
| server := &http.Server{ | ||
| Addr: opt.Server.Listen, | ||
| TLSConfig: &tls.Config{ | ||
| MinVersion: tls.VersionTLS12, | ||
| PreferServerCipherSuites: true, |
There was a problem hiding this comment.
Ah, I see PreferServerCipherSuites is deprecated & ignored now.
|
|
||
| var contextKey contextKeyType | ||
|
|
||
| func FromContext(ctx context.Context) *VFSContext { |
There was a problem hiding this comment.
Not sure we don't end up reintroducing this, but it's in version control so ....
|
Thanks @johngmyers /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
This comment was marked as spam.
This comment was marked as spam.
No description provided.