Update references to control-plane-count #15733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubetest2-kops searches for create-args values of --control-plane-count. While kops recognizes both --control-plane-count and --master-count, kubetest2-kops will add --control-plane-count if it isn't already set in --create-args. This means any references to --master-count need to be updated to --control-plane-count.
k8s-ci-robot
added
cncf-cla: yes
hakman
approved these changes
Aug 2, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubetest2-kops searches for create-args values of --control-plane-count. While kops recognizes both --control-plane-count and --master-count, kubetest2-kops will add --control-plane-count if it isn't already set in --create-args. This means any references to --master-count need to be updated to --control-plane-count.
This should fix at least this job: https://testgrid.k8s.io/kops-gce#kops-leader-migration
I0801 22:50:40.366862 5814 local.go:42] ⚙️ /home/prow/go/src/k8s.io/kops/_rundir/121db271-a4e7-46bc-842f-abf92494756d/kops create cluster --name ha-migration.k8s.local --cloud gce --kubernetes-version v1.23.17 --ssh-public-key /tmp/kops-ssh2613636737/key.pub --set cluster.spec.nodePortAccess=0.0.0.0/0 --channel=alpha --node-count=1 --master-count=3 --zones=us-central1-a,us-central1-b,us-central1-c --master-zones=us-central1-a,us-central1-b,us-central1-c --gce-service-account=default --admin-access 35.224.130.54/32 --control-plane-count 1 --master-volume-size 48 --node-volume-size 48 --master-size e2-standard-2 --project k8s-kubeadm-1-6-on-1-7 I0801 22:50:40.455002 6136 create_cluster.go:885] Using SSH public key: /tmp/kops-ssh2613636737/key.pub I0801 22:50:40.760691 6136 new_cluster.go:579] VMs will be configured to use specified Service Account: default Error: specified 3 control-plane zones, but also requested 1 control-plane nodes. If specifying both, the count should match.