Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack: Add missing security groups for cilium etcd #15766

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

zadjadr
Copy link
Contributor

@zadjadr zadjadr commented Aug 10, 2023

Fixes #15765

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @zadjadr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2023
pkg/model/openstackmodel/firewall.go Show resolved Hide resolved
pkg/model/openstackmodel/firewall.go Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented Aug 11, 2023

/cc @olemarkus
/assign @zetaab

@olemarkus
Copy link
Member

Approach and rules looks good to me.

@zadjadr
Copy link
Contributor Author

zadjadr commented Aug 11, 2023

Seems like I missed 4003 from workers to master was also needed.
The cilium-agent pods on the workers would complain:

cilium-agent level=error msg="Unable to initialize local node. Retrying..." error="timeout while retrieving initial list of objects from kvstore" subsys=nodediscovery

@hakman hakman changed the title Add missing security groups for cilium etcd openstack: Add missing security groups for cilium etcd Aug 11, 2023
@hakman
Copy link
Member

hakman commented Aug 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2023
@zadjadr
Copy link
Contributor Author

zadjadr commented Aug 11, 2023

Sorry, this should be the final addition.. When creating a new cluster, etcd tries to also check port 3992 (Master to Master)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2023
@hakman
Copy link
Member

hakman commented Aug 12, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit e4177a3 into kubernetes:master Aug 12, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium EtcdManaged SecurityGroups missing
5 participants