Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new field for using a custom registry for Cilium #15787

Conversation

jandersen-plaid
Copy link
Contributor

Fixes #15786.

There is a bit more context in the issue, but this adds a Registry field to the CiliumNetworkingSpec so that users can override the image registry used to pull Cilium images.

This copies the method used for similar Networking add ons when specifying a Registry argument in their NetworkingSpec; defaulting to quay.io when the Registry field is empty.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jandersen-plaid. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2023
@hakman
Copy link
Member

hakman commented Aug 16, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2023
@hakman
Copy link
Member

hakman commented Aug 16, 2023

@jandersen-plaid Please rebase to pass the tests.

@jandersen-plaid jandersen-plaid force-pushed the jandersen-plaid-cilium-custom-image branch from 7d5a20f to 84655d5 Compare August 17, 2023 14:07
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @jandersen-plaid! 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@hakman
Copy link
Member

hakman commented Aug 17, 2023

Sorry, I think you will need to rebase one more time it tests don't pass...

@hakman
Copy link
Member

hakman commented Aug 17, 2023

/test all

Signed-off-by: Jack Andersen <jandersen@plaid.com>
@jandersen-plaid jandersen-plaid force-pushed the jandersen-plaid-cilium-custom-image branch from 84655d5 to af6269f Compare August 17, 2023 14:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@hakman
Copy link
Member

hakman commented Aug 17, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 30769a5 into kubernetes:master Aug 17, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Aug 17, 2023
@jandersen-plaid jandersen-plaid deleted the jandersen-plaid-cilium-custom-image branch August 17, 2023 16:17
k8s-ci-robot added a commit that referenced this pull request Aug 20, 2023
…-upstream-release-1.27

Automated cherry pick of #15787: Add a new field for using a custom registry for Cilium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to override the default Cilium Registry in the networking addon
3 participants