-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new field for using a custom registry for Cilium #15787
Add a new field for using a custom registry for Cilium #15787
Conversation
Hi @jandersen-plaid. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@jandersen-plaid Please rebase to pass the tests. |
7d5a20f
to
84655d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @jandersen-plaid! 😄
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry, I think you will need to rebase one more time it tests don't pass... |
/test all |
Signed-off-by: Jack Andersen <jandersen@plaid.com>
84655d5
to
af6269f
Compare
/lgtm |
…-upstream-release-1.27 Automated cherry pick of #15787: Add a new field for using a custom registry for Cilium
Fixes #15786.
There is a bit more context in the issue, but this adds a
Registry
field to theCiliumNetworkingSpec
so that users can override the image registry used to pull Cilium images.This copies the method used for similar Networking add ons when specifying a
Registry
argument in their NetworkingSpec; defaulting toquay.io
when theRegistry
field is empty.