-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Replace ForAPIServer with WellKnownServices #15829
Refactor: Replace ForAPIServer with WellKnownServices #15829
Conversation
/milestone v1.29 |
pkg/model/bootstrapscript.go
Outdated
} | ||
|
||
// WellKnownAddresses holds known addresses for well-known services | ||
type WellKnownAddresses struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something more like a map[wellknownservices.WellKnownService][]string
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea - converted to a type alias on the map.
00b8915
to
1baeef3
Compare
I remembered why this one is important ... doing this will let us set up two apiservers, one for internal traffic and one for external traffic, which is needed for GCE firewalling, which is needed for GCE dns=none |
We instead return a list of the services we are supporting. We can in future split out internal and external apiserver services.
1baeef3
to
ae226db
Compare
/test pull-kops-e2e-k8s-aws-calico |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We instead return a list of the services we are supporting.
We can in future split out internal and external apiserver services.