Automated cherry pick of #15565: etcd-manager: support symlinking versions #15832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/hold Had to do some heavier editing to get this one to apply cleanly |
k8s-ci-robot
added
the
do-not-merge/hold
This is an easy way for us to signal that certain versions are compatible with each to etcd-manager, which is otherwise overly-cautious when it comes to unknown versions. We extend kops-utils to support the `-t` flag (like cp) to write to a directory; and the `-s` flag (like cp) to use symlinks. The syntax isn't identical to cp, but should be semi-familiar and allows us to minimize the number of initContainers we use.
justinsb
force-pushed
the
automated-cherry-pick-of-#15565-upstream-release-1.27
branch
from
28f54c6
to
84ac5d2
Compare
|
This should address #15832 It is only a partial cherry-pick because we don't pull in the symlinking, so we don't make too many changes on the 1.27 branch. |
|
Seems to fix the restart problem so /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
hakman
approved these changes
Aug 27, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #15565 on release-1.27.
#15565: etcd-manager: support symlinking versions
For details on the cherry pick process, see the cherry pick requests page.