Improve status printing when tasks are in progress #15847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test all |
justinsb
commented
Aug 31, 2023
Previously we were implying that the tasks were somehow failing,but this isn't quite right when they emit the try-again-later error. Also pretty-print the pluralization while we're here.
justinsb
force-pushed
the
better_status_messages
branch
from
f3dfe12
to
e675331
Compare
hakman
reviewed
Aug 31, 2023
|
/test pull-kops-e2e-k8s-aws-calico |
1 similar comment
|
/test pull-kops-e2e-k8s-aws-calico |
|
@justinsb I guess something broke when pushing dns-conroller.tgz to bucket. Can you force push to try and fix it? |
|
/test pull-kops-e2e-k8s-aws-calico |
hakman
reviewed
Sep 4, 2023
k8s-ci-robot
added
size/S
hakman
approved these changes
Sep 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/milestone v1.29 |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were implying that the tasks were somehow failing,but
this isn't quite right when they emit the try-again-later error.
Also pretty-print the pluralization while we're here.