Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warmpool to expose dependencies for dependency analysis #15848

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

justinsb
Copy link
Member

We should populate the AutoscalingGroup field, so that it can be used
by dependency analysis.

We should populate the AutoscalingGroup field, so that it can be used
by dependency analysis.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Aug 31, 2023
@justinsb
Copy link
Member Author

Not particularly urgent, as we seem to be getting away with this one, and worst case it should just be an extra retry.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit f61939b into kubernetes:master Sep 4, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Sep 4, 2023
k8s-ci-robot added a commit that referenced this pull request Sep 4, 2023
…5848-upstream-release-1.27

Automated cherry pick of #15848: Fix warmpool to expose dependencies for dependency analysis
k8s-ci-robot added a commit that referenced this pull request Sep 4, 2023
…5848-upstream-release-1.28

Automated cherry pick of #15848: Fix warmpool to expose dependencies for dependency analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants