Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mixed instances for scale tests #15859

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Use mixed instances for scale tests #15859

merged 1 commit into from
Sep 4, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 3, 2023 •
edited
Loading 

  AutoscalingGroup/nodes-us-east-2a.e2e-ff02749ef8-a423a.test-cncf-aws.k8s.io
  	MixedInstanceOverrides	[c7g.large, c6g.large, t4g.large, m7g.large, m6g.large, r7g.large, r6g.large]

@hakman
Copy link
Member Author

hakman commented Sep 3, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2023
@hakman hakman requested review from dims and justinsb and removed request for olemarkus and zetaab September 3, 2023 05:58
@hakman
Copy link
Member Author

hakman commented Sep 3, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@dims
Copy link
Member

dims commented Sep 3, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2023
@hakman
Copy link
Member Author

hakman commented Sep 3, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2023
@hakman
Copy link
Member Author

hakman commented Sep 3, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

2 similar comments
@hakman
Copy link
Member Author

hakman commented Sep 3, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member Author

hakman commented Sep 4, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member Author

hakman commented Sep 4, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@justinsb
Copy link
Member

justinsb commented Sep 4, 2023

Thanks @hakman

/approve
/lgtm

/hold for test results (if you're waiting for them)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@hakman
Copy link
Member Author

hakman commented Sep 4, 2023

Thanks @justinsb, all tests are green now!
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit efab9bc into kubernetes:master Sep 4, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 4, 2023
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@dims dims

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @dims @justinsb @k8s-ci-robot