Only run one replica of controller pods on non-HA clusters #15868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/L
Even when running on workers (using IRSA), if we try to run multiple controllers we may have problems with node-spreading, and we don't necessarily gain any availability, as we need an apiserver lease. Issue kubernetes#15852
justinsb
force-pushed
the
fix_issue_15852
branch
from
193d739
to
9daf090
Compare
|
Assuming we agree with this approach, there is a risk that we break e.g. a PodDisruptionBudget during a rolling update. I propose we merge to 1.28 first, then cherry pick to 1.27 (but not necessarily 1.27.1, as I don't think this is a regression, it only occurs with IRSA + a cluster with a single worker node) |
|
/test pull-kops-e2e-k8s-gce-ipalias |
|
/milestone v1.28 |
johngmyers
approved these changes
Sep 4, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 6, 2023
…-upstream-release-1.28 Automated cherry pick of #15868: Only run one replica of controller pods on non-HA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when running on workers (using IRSA), if we try to run multiple
controllers we may have problems with node-spreading, and we don't
necessarily gain any availability, as we need an apiserver lease.
Issue #15852