Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metadata-proxy from GCE Clusters from 1.29+ onwards #15885

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Remove metadata-proxy from GCE Clusters from 1.29+ onwards #15885

merged 1 commit into from
Sep 9, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Sep 7, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/api labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2023
@upodroid upodroid changed the title [WIP] Allow disabling metadata-proxy Allow disabling metadata-proxy Sep 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2023
johngmyers
johngmyers reviewed Sep 8, 2023
View reviewed changes
pkg/apis/kops/cluster.go Outdated Show resolved Hide resolved
pkg/model/components/gcpmetadataproxy.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/bootstrapchannelbuilder/bootstrapchannelbuilder.go Outdated Show resolved Hide resolved
@upodroid
Copy link
Member Author

upodroid commented Sep 8, 2023

Changing the PR to remove the feature entirely as discussed during the office hours. GCP deprecated this product a long time ago from GKE and the source code for it isn't around.

@johngmyers
Copy link
Member

The Office Hours decision was to remove it as of Kubernetes 1.29. If the Kubernetes version is 1.28 or earlier then it should still be installed.

Do we need to add any code to get it removed upon upgrade over the 1.29 boundary?

@upodroid
Copy link
Member Author

upodroid commented Sep 8, 2023

Fixed

@upodroid upodroid changed the title Allow disabling metadata-proxy Remove metadata-proxy from GCE Clusters from 1.29+ onwards Sep 8, 2023
@upodroid
Copy link
Member Author

upodroid commented Sep 8, 2023

/test pull-kops-e2e-k8s-gce-ci

@upodroid
Copy link
Member Author

upodroid commented Sep 8, 2023

Verified the changes in the pull-kops-e2e-k8s-gce-ci job which is testing against 1.29

@upodroid
Copy link
Member Author

upodroid commented Sep 9, 2023

/retest

@johngmyers
Copy link
Member

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@upodroid
Copy link
Member Author

upodroid commented Sep 9, 2023

These jobs should have focus_regex to Conformance

hakman
hakman requested changes Sep 9, 2023
View reviewed changes
docs/releases/1.28-NOTES.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@hakman
Copy link
Member

hakman commented Sep 9, 2023

These jobs should have focus_regex to Conformance

We can debate this at the next kOps Office Hours. 😆

@hakman
Copy link
Member

hakman commented Sep 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@hakman
Copy link
Member

hakman commented Sep 9, 2023

/test pull-kops-e2e-k8s-gce-ci

@k8s-ci-robot
Copy link
Contributor

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-ci 7ee84a7 link true /test pull-kops-e2e-k8s-gce-ci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@upodroid
Copy link
Member Author

upodroid commented Sep 9, 2023

I'm seeing infra bugs

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/15885/pull-kops-e2e-k8s-gce-ci/1700408126739582976/build-log.txt

my-hostname-private-cc309a20-27eb-4138-8dd2-b86c8864d452-j7pjv

image

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@upodroid
Copy link
Member Author

upodroid commented Sep 9, 2023

Fixed the docs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit a7555dc into kubernetes:master Sep 9, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 9, 2023
@upodroid upodroid mentioned this pull request Oct 2, 2023
Open
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@hakman hakman hakman approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@johngmyers johngmyers

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@upodroid @johngmyers @hakman @k8s-ci-robot