Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cilium: Implement node encryption #15901

Merged

Conversation

zadjadr
Copy link
Contributor

@zadjadr zadjadr commented Sep 11, 2023

Fixes: #15853

In 1.13 and below, the node encryption only works with IPsec and from 1.14 and above it only works with wireguard.

There is no extra validation added, because the setting will be ignored if you have wiredguard + nodeEncryption + cilum 1.13 or ipsec + nodeEncryption + cilium 1.14.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added area/addons area/api needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @zadjadr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2023
@zadjadr zadjadr changed the title Implement node encryption Cilium: Implement node encryption Sep 11, 2023
@hakman
Copy link
Member

hakman commented Sep 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2023
@zadjadr
Copy link
Contributor Author

zadjadr commented Sep 22, 2023

@hakman can this be merged?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@hakman
Copy link
Member

hakman commented Sep 22, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0a0f938 into kubernetes:master Sep 22, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 22, 2023
k8s-ci-robot added a commit that referenced this pull request Sep 23, 2023
…-upstream-release-1.28

Automated cherry pick of #15901: Implement node encryption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NodeEncryption (beta) to Cilium
3 participants