Handle 404 properly from Service Accounts API #15902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
upodroid
commented
Sep 11, 2023
upodroid
commented
- Capitalized a few resources to match their names
- If you cancel kubetest2 before the tests start running, you end up in a weird state where it tries to delete service accounts after they had been deleted. This change fixes that
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
hakman
requested changes
Sep 11, 2023
upodroid
force-pushed
the
gce-sva-bug-fix
branch
from
9553399
to
352566c
Compare
johngmyers
reviewed
Sep 11, 2023
| return nil | ||
| } | ||
| return fmt.Errorf("error deleting disk %s: %v", t.SelfLink, err) | ||
| return fmt.Errorf("error deleting Disk %s: %v", t.SelfLink, err) |
There was a problem hiding this comment.
Error messages should not start with the word "error"
Suggested change
| return fmt.Errorf("error deleting Disk %s: %v", t.SelfLink, err) | |
| return fmt.Errorf("deleting Disk %s: %v", t.SelfLink, err) |
There was a problem hiding this comment.
I'll do it in a followup PR
hakman
approved these changes
Sep 11, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.