Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: Fix minor typos for Karpenter setup #15935

Merged
merged 2 commits into from
Sep 23, 2023
Merged

aws: Fix minor typos for Karpenter setup #15935

merged 2 commits into from
Sep 23, 2023

Conversation

junm-cloudnatix
Copy link
Contributor

on-demand is the right string to indicate OnDemand in Karpenter. See: https://github.com/aws/karpenter-core/blob/main/pkg/apis/v1alpha5/labels.go#L30 As the result it does not fall back to ondemand instances.

Also add ec2:DescribeImages to karpenter IAM policies -- it's noted in https://karpenter.sh/docs/getting-started/migrating-from-cas/#create-iam-roles (the list also has DeleteLaunchTemplates but I don't think this is necessary for kOps).

@junm-cloudnatix
Fix minor typos for karpenter setup.
0573e6d 
`on-demand` is the right string to indicate OnDemand in Karpenter.
See: https://github.com/aws/karpenter-core/blob/main/pkg/apis/v1alpha5/labels.go#L30
As the result it does not fall back to ondemand instances.

Also add `ec2:DescribeImages` to karpenter IAM policies -- it's
noted in https://karpenter.sh/docs/getting-started/migrating-from-cas/#create-iam-roles
(the list also has DeleteLaunchTemplates but I don't think this
is necessary for kOps).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @junm-cloudnatix!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @junm-cloudnatix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2023
@hakman
Copy link
Member

hakman commented Sep 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@junm-cloudnatix
Copy link
Contributor Author

/retest

@hakman
Copy link
Member

hakman commented Sep 22, 2023

@junm-cloudnatix We are having some trouble with our Karpenter tests. I will try to find the root cause early next week. Sorry for the trouble validating the PR.

@ndallavalentina
Copy link

ndallavalentina commented Sep 22, 2023 •
edited
Loading

This pr will solve this issue: #15948

@hakman hakman changed the title Fix minor typos for karpenter setup. Fix minor typos for Karpenter setup. Sep 23, 2023
@hakman
Copy link
Member

hakman commented Sep 23, 2023

/test pull-kops-e2e-aws-karpenter

@hakman hakman changed the title Fix minor typos for Karpenter setup. aws: Fix minor typos for Karpenter setup. Sep 23, 2023
@hakman hakman changed the title aws: Fix minor typos for Karpenter setup. aws: Fix minor typos for Karpenter setup Sep 23, 2023
@hakman
Copy link
Member

hakman commented Sep 23, 2023

/test all

@hakman
Copy link
Member

hakman commented Sep 23, 2023

/retest

2 similar comments
@hakman
Copy link
Member

hakman commented Sep 23, 2023

/retest

@hakman
Copy link
Member

hakman commented Sep 23, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit bd6c685 into kubernetes:master Sep 23, 2023
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 23, 2023
@hakman
Copy link
Member

hakman commented Sep 23, 2023

Thanks @junm-cloudnatix!

@hakman hakman mentioned this pull request Sep 24, 2023
Closed
@danports danports mentioned this pull request Sep 24, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 24, 2023
@k8s-ci-robot
Merge pull request #15958 from danports/automated-cherry-pick-of-#15935-
f253613 
#15957-upstream-release-1.28

Automated cherry pick of #15935: Fix minor typos for karpenter setup.
#15957: Configure Karpenter resources.
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@junm-cloudnatix @k8s-ci-robot @hakman @ndallavalentina