Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gce: Remove custom resolver #16189

Merged
merged 1 commit into from
Dec 23, 2023
Merged

gce: Remove custom resolver #16189

merged 1 commit into from
Dec 23, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 23, 2023 •
edited
Loading

Not needed anymore with dns=none.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2023
@hakman
Copy link
Member Author

hakman commented Dec 23, 2023

/test pull-kops-e2e-gce-dns-none

@hakman
Copy link
Member Author

hakman commented Dec 23, 2023

/test pull-kops-e2e-k8s-gce-cilium
/test pull-kops-e2e-gce-dns-none

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 23, 2023 •
edited
Loading

@hakman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-gce-dns-none 0be0241 link true /test pull-kops-e2e-gce-dns-none

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman
Copy link
Member Author

hakman commented Dec 23, 2023

/cc @upodroid

upodroid
upodroid approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2023
@hakman
Copy link
Member Author

hakman commented Dec 23, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4850546 into kubernetes:master Dec 23, 2023
21 of 22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 23, 2023
@hakman hakman deleted the remove_custom_resolver branch December 24, 2023 10:53
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @upodroid