Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert-manager resource types to kubetest2-kops artifacts #16193

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

rifelpet
Copy link
Member

The LBC prow job is flaking. I believe its due to a race condition that still exists. I'm adding the cert-manager resources that the LBC addon includes to help with troubleshooting

https://testgrid.k8s.io/kops-misc#kops-aws-aws-load-balancer-controller

Signed-off-by: Peter Rifel <pgrifel@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2023
@hakman
Copy link
Member

hakman commented Dec 28, 2023

@rifelpet We should investigate the dumper at some point. All the new namespaces and resource types are taking a very long time to be dumped.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 26c42f4 into kubernetes:master Dec 28, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants