Dont list and terminate ASG-managed EC2 instances

[rifelpet]

/hold for feedback

Looking at scale tests, kops delete cluster spends 6 minutes trying to terminate all of the ec2 instances. In reality this shouldn't be necessary because kops also deletes the ASGs (which appear to happen much faster) and the ASGs will terminate the instances.

I dont know how the timing compares but it should at least eliminate the throttled API calls.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rifelpet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

Both me and @upodroid thought about this and I think it's a good idea.
The problem is that other resources depend on instances, like volumes and would leave those resources hanging (maybe).

[rifelpet]

Both me and @upodroid thought about this and I think it's a good idea.

The problem is that other resources depend on instances, like volumes and would leave those resources hanging (maybe).

Could we have volumes depend on the ASGs instead? What I'm not sure about is if all instances are gone at the time that the ASG deletion returns, or whether AWS is still in the process of terminating them.

[hakman]

Both me and @upodroid thought about this and I think it's a good idea.
The problem is that other resources depend on instances, like volumes and would leave those resources hanging (maybe).

Could we have volumes depend on the ASGs instead? What I'm not sure about is if all instances are gone at the time that the ASG deletion returns, or whether AWS is still in the process of terminating them.

Or we could just have instances that have non-root volumes added to the list.
I think listing the instances should still be done. We still have some case where we create ec2 instance for maybe NAT?

[rifelpet]

Replaced by #16229