-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: Ignore InvalidRouteTableID.NotFound errors during cluster deletion #16252
aws: Ignore InvalidRouteTableID.NotFound errors during cluster deletion #16252
Conversation
/cc @rifelpet |
@@ -806,7 +806,7 @@ func ListSubnets(cloud fi.Cloud, vpcID, clusterName string) ([]*resources.Resour | |||
|
|||
rtRequest := &ec2.DescribeRouteTablesInput{} | |||
rtResponse, err := c.EC2().DescribeRouteTables(rtRequest) | |||
if err != nil { | |||
if err != nil && awsup.AWSErrorCode(err) != "InvalidRouteTableID.NotFound" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first for
loop below this will panic because rtResponse
will be nil. same with the other change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed
d4f152d
to
fd86a0c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-conformance-1-28/1746126431886249984/build-log.txt