Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update images.md #16454

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Update images.md #16454

merged 4 commits into from
Apr 7, 2024

Conversation

esbc-disciple
Copy link
Contributor

include explicit instructions on pulling arm64-based images

@esbc-disciple
Update images.md
38e92f9 
include explicit instructions on pulling arm64-based images
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @esbc-disciple!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @esbc-disciple. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2024
@hakman
Copy link
Member

hakman commented Apr 6, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2024
hakman
hakman requested changes Apr 7, 2024
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @esbc-disciple, thank you for trying to add more info on how to use ARM64. Nice to see such initiative. I added a few comments. Please take a look.

docs/operations/images.md Outdated
@@ -1,8 +1,8 @@
# Images

As of Kubernetes 1.27 the default images used by kOps are the **[official Ubuntu 22.04](#ubuntu-2204-jammy)** images.
As of Kubernetes 1.27 the default images used by kOps are the x86_64 (amd64) **[official Ubuntu 22.04](#ubuntu-2204-jammy)** images. If you want to pull the default kOps image, but for an arm64 processor architecture, you can specify an arm64-based instance name in the --control-plane-size and --node-size parameters of the kops create cluster command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topic here is how to find the right images and I don't think this change adds more clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, especially in light of the edits you made to commands, adding a wildcard in the proc-architecture position of the search string.

My thought process in adding this note was to try to help folks bring up their ARM64 instances without editing config (which is super helpful when you are just getting started and learning). I am OK with it being nixed, nonetheless. With the edit to the search strings, folks should be able to read between the lines on how to instantiate ARM images.

docs/operations/images.md Outdated Show resolved Hide resolved
docs/operations/images.md Outdated
@@ -84,6 +84,15 @@ aws ec2 describe-images --region us-east-1 --output table \
--filters "Name=name,Values=al2023-ami-2*-kernel-6.1-x86_64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should offer the same value as adding a new command for ARM64.
I suggest this approach, instead of new commands.

Suggested change
--filters "Name=name,Values=al2023-ami-2*-kernel-6.1-x86_64"
--filters "Name=name,Values=al2023-ami-2*-kernel-6.1-*"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is a Homer Simpson d'oh moment on my part! The way you suggested is much cleaner.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens some times to me too... 😆
Please apply this in all the cases and all other suggestions.

esbc-disciple and others added 2 commits April 6, 2024 22:44
@esbc-disciple @hakman
Update docs/operations/images.md
fd7a434 
make image search commands processor-architecture-agnostic

Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
@esbc-disciple
Update images.md
f91db46 
change image search strings to also capture arm process architecture
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2024
@esbc-disciple @hakman
Update docs/operations/images.md
a476da9 
Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
@esbc-disciple
Copy link
Contributor Author

@hakman,

I committed the changes we discussed. Let me know if I need to do anything else. Thank you for making it easy to suggest changes!

hakman
hakman approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2024
@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 91e299d into kubernetes:master Apr 7, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Apr 7, 2024
@BrewTestBot BrewTestBot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@esbc-disciple @k8s-ci-robot @hakman