Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service account issuer migration doc #16541

Merged
merged 2 commits into from
May 16, 2024

Conversation

elliotdobson
Copy link
Contributor

Adds docs for non-disruptive migration of the Service Account Issuer in an existing cluster, as discovered in #16488.

In the future I will update this doc with the same procedure using the kOps official support from #16497, once I have tested it.

Copy link

linux-foundation-easycla bot commented May 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @elliotdobson!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @elliotdobson. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from hakman May 8, 2024 00:16
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 8, 2024
@hakman
Copy link
Member

hakman commented May 11, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2024
@elliotdobson
Copy link
Contributor Author

Having a look at the Netlify documentation preview I do not see the new page in the Operations side bar, but the Service Account Issuer (SAI) migration page exists. Do I need to add something?

@hakman
Copy link
Member

hakman commented May 16, 2024

Thank you @elliotdobson, I hope this will help many people in the future!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@elliotdobson
Copy link
Contributor Author

Having a look at the Netlify documentation preview I do not see the new page in the Operations side bar, but the Service Account Issuer (SAI) migration page exists. Do I need to add something?

Is this the same for you @hakman?

@k8s-ci-robot k8s-ci-robot merged commit 937663a into kubernetes:master May 16, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone May 16, 2024
@hakman
Copy link
Member

hakman commented May 16, 2024

Having a look at the Netlify documentation preview I do not see the new page in the Operations side bar, but the Service Account Issuer (SAI) migration page exists. Do I need to add something?

Is this the same for you @hakman?

You are right, I will look into what's missing. Thanks!

@hakman
Copy link
Member

hakman commented May 16, 2024

@elliotdobson Could you add the doc to this list (in a new PR)?

kops/mkdocs.yml

Lines 74 to 98 in a4b9980

- Operations:
- Updates & Upgrades: "operations/updates_and_upgrades.md"
- Rolling Updates: "operations/rolling-update.md"
- Working with Instance Groups: "tutorial/working-with-instancegroups.md"
- Using Manifests and Customizing: "manifests_and_customizing_via_api.md"
- High Availability: "operations/high_availability.md"
- Scaling: "operations/scaling.md"
- Karpenter: "operations/karpenter.md"
- Local asset repositories: "operations/asset-repository.md"
- Instancegroup images: "operations/images.md"
- Cluster configuration management: "changing_configuration.md"
- Cluster Templating: "operations/cluster_template.md"
- GPU setup: "gpu.md"
- Label management: "labels.md"
- Rotate Secrets: "operations/rotate-secrets.md"
- Service Account Token Volume: "operations/service_account_token_volumes.md"
- Moving from a Single Master to Multiple HA Masters: "single-to-multi-master.md"
- Running kOps in a CI environment: "continuous_integration.md"
- Gossip DNS: "gossip.md"
- etcd:
- etcd administration: "operations/etcd_administration.md"
- etcd backup, restore and encryption: "operations/etcd_backup_restore_encryption.md"
- Moving from a Single Master to Multiple HA Masters: "single-to-multi-master.md"
- etcd3 Migration: "etcd3-migration.md"
- Troubleshooting: "operations/troubleshoot.md"

@elliotdobson
Copy link
Contributor Author

Done in #16573.

@elliotdobson elliotdobson deleted the esd-sai-migration-docs branch May 16, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants