Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use version from go.mod in github actions #16550

Merged
merged 1 commit into from
May 16, 2024
Merged

tests: use version from go.mod in github actions #16550

merged 1 commit into from
May 16, 2024

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented May 9, 2024

  • Bump golang to 1.22.3
  • tests: use version from go.mod in github actions

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2024
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab May 9, 2024 11:47
@hakman
Copy link
Member

hakman commented May 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2024
@justinsb @hakman
tests: use version from go.mod in github actions
08bcc79 
This reduces the duplication of the go version.
@hakman hakman force-pushed the githubactions_source_go_version_from_gomod branch from a467507 to 08bcc79 Compare May 16, 2024 03:28
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 16, 2024
@hakman hakman changed the title WIP: tests: use version from go.mod in github actions tests: use version from go.mod in github actions May 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 672d952 into kubernetes:master May 16, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone May 16, 2024
@hakman hakman mentioned this pull request Jun 15, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 15, 2024
@k8s-ci-robot
Merge pull request #16619 from hakman/automated-cherry-pick-of-#16550-#…
fae4122 
…16618-upstream-release-1.29

Automated cherry pick of #16550: tests: use version from go.mod in github actions
#16618: Update Go to v1.21.4
@BrewTestBot BrewTestBot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @hakman @k8s-ci-robot