-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node-termination-handler to 1.22.0 #16572
Conversation
Hi @jim-barber-he. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I've created 2 commits so that you can see my changes in the first one, then the 2nd one has 209 test files updated from running |
Node Termination Handler v1.22.0 was released a moment ago. There are no changes to the helm charts apart from bumping the version, so I may as well change this to use it. |
/ok-to-test |
pkg/apis/kops/componentconfig.go
Outdated
// DeleteSqsMsgIfNodeNotFound makes node termination handler delete the SQS Message from the SQS Queue if the targeted node is not found. | ||
// Only used in Queue Processor mode. | ||
// Default: false | ||
DeleteSqsMsgIfNodeNotFound *bool `json:"deleteSqsMsgIfNodeNotFound,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQS should be in uppercase.
DeleteSqsMsgIfNodeNotFound *bool `json:"deleteSqsMsgIfNodeNotFound,omitempty"` | |
DeleteSQSMsgIfNodeNotFound *bool `json:"deleteSQSMsgIfNodeNotFound,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Also allow to specify the following extra parameters for it. - deleteSqsMsgIfNodeNotFound - memoryLimit - podTerminationGracePeriod - taintNode - webhookTemplate Signed-off-by: Jim Barber <jim.barber@healthengine.com.au>
Signed-off-by: Jim Barber <jim.barber@healthengine.com.au>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jim-barber-he! 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do you need/want the 2x commits squashed into 1? |
Nop, all good. Thanks! |
@hakman Will this be in the next kops 1.29 release? |
@jim-barber-he Sure, I don't see any issue with that. Thanks! |
…f-#16572-upstream-release-1.29 Automated cherry pick of #16572: Upgrade node-termination-handler to 1.22.0
Also allow to specify the following extra parameters for it.