Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Fix conversion for instance-selector flags #16776

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 25, 2024

Closes #16775

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2024
@hakman
Copy link
Member Author

hakman commented Aug 25, 2024

/test pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0c586a6 into kubernetes:master Aug 25, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 25, 2024
k8s-ci-robot added a commit that referenced this pull request Aug 25, 2024
…76-origin-release-1.30

Automated cherry pick of #16776: aws: Fix conversion for instance-selector flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kops toolbox instance-selector command bug: panic: interface conversion: interface {} is *string, not string
3 participants