-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #16778: dns: don't use IMDS region resolver when it previously failed #16781
Automated cherry pick of #16778: dns: don't use IMDS region resolver when it previously failed #16781
Conversation
This should allow use to IMDS on EC2, but not when not running on EC2, for example when running `kops update cluster`.
/hold https://testgrid.k8s.io/kops-misc#kops-aws-external-dns https://testgrid.k8s.io/kops-misc#kops-aws-pod-identity-webhook |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For kops-aws-pod-identity-webhook, I think this is the error:
So ACLs on the S3 bucket - I think we try to detect that, so maybe that's going wrong. For https://testgrid.k8s.io/kops-misc#kops-aws-apiserver-nodes, we're getting further, but the most recent test failed to connect to the cluster and then could not SSH to the VMs to dump more info. It almost looked like they didn't come up at all, which is ... odd. On the toolbox dump the instances do have state=running (but I can't easily tell for how long). We do create the cluster from a template here, so it's not unlikely that something else is going wrong here. |
(I have no objection to delaying the backport by the way, while we figure this out!) |
@justinsb this is my main concern with merging this as-is. I think a follow up is needed: |
The remaining failures are unrelated, so this should be safe to merge /unhold |
Cherry pick of #16778 on release-1.30.
#16778: dns: don't use IMDS region resolver when it previously failed
For details on the cherry pick process, see the cherry pick requests page.