Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #16778: dns: don't use IMDS region resolver when it previously failed #16781

Conversation

rifelpet
Copy link
Member

Cherry pick of #16778 on release-1.30.

#16778: dns: don't use IMDS region resolver when it previously failed

For details on the cherry pick process, see the cherry pick requests page.


This should allow use to IMDS on EC2, but not when not running on EC2,
for example when running `kops update cluster`.
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2024
@rifelpet
Copy link
Member Author

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@justinsb
Copy link
Member

For kops-aws-pod-identity-webhook, I think this is the error:

Error: error running tasks: deadline exceeded executing task ManagedFile/discovery.json. Example error: error creating ManagedFile ".well-known/openid-configuration": error writing s3://k8s-kops-ci-prow-state-store/e2e-49d63c55eb-ac683.tests-kops-aws.k8s.io/.well-known/openid-configuration (with ACL="public-read"): operation error S3: PutObject, https response error StatusCode: 400, RequestID: M0XPHJR0EZRXMPXD, HostID: d+e5r1Lc7v47eYOlLjCTJe8L/r5lmPJ6gvuY7nNY2pEU1wlEN+3LJayd33Os1KQFoddackAfxeE=, api error AccessControlListNotSupported: The bucket does not allow ACLs

So ACLs on the S3 bucket - I think we try to detect that, so maybe that's going wrong.


For https://testgrid.k8s.io/kops-misc#kops-aws-apiserver-nodes, we're getting further, but the most recent test failed to connect to the cluster and then could not SSH to the VMs to dump more info. It almost looked like they didn't come up at all, which is ... odd. On the toolbox dump the instances do have state=running (but I can't easily tell for how long). We do create the cluster from a template here, so it's not unlikely that something else is going wrong here.

@justinsb
Copy link
Member

(I have no objection to delaying the backport by the way, while we figure this out!)

@rifelpet
Copy link
Member Author

@justinsb this is my main concern with merging this as-is. I think a follow up is needed:

#16778 (comment)

@rifelpet
Copy link
Member Author

The remaining failures are unrelated, so this should be safe to merge

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit afd6aad into kubernetes:release-1.30 Aug 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants