Fix ipv6 prefix detection with aws-sdk-go-v2 #16809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS ipv6 jobs have been failing with this nodeup error:
This occurs in the task's Find method. We should just return nil (indicating the resource doesn't exist yet and needs to be created) but there was a bug in the error handling in aws-sdk-go-v2 and we weren't identifying the request as a 404.
The SDK's IMDS client uses different error types from normal services, so we have to unwrap the error differently:
https://github.com/aws/aws-sdk-go-v2/blob/f1d71c59a1499981873f70db8c92d07242779670/feature/ec2/imds/request_middleware.go#L185-L191
Once we confirm this fixes all of the failing ipv6 jobs then we should cherrypick this to 1.30