Allow updating the cluster one instance group at a time #16936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
justinsb
force-pushed
the
filter_instance_groups
branch
from
c8cbd1d
to
9ea91a1
Compare
hakman
approved these changes
Nov 9, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Some tests output needs updating. |
k8s-ci-robot
removed
the
lgtm
justinsb
force-pushed
the
filter_instance_groups
branch
from
9ea91a1
to
be01cfe
Compare
Co-Authored-By: Ciprian Hacman <ciprianhacman@gmail.com>
justinsb
force-pushed
the
filter_instance_groups
branch
from
be01cfe
to
1683894
Compare
k8s-ci-robot
added
area/documentation
area/provider/azure
|
@justinsb Looks like it's missing one last |
justinsb
force-pushed
the
filter_instance_groups
branch
from
ca61335
to
b4306a3
Compare
🤞 this time. Sometimes gopls just doesn't want to format 😂 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Ciprian Hacman ciprianhacman@gmail.com