Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: change log level from error to info #465

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

caozhuozi
Copy link
Contributor

I'm not sure why the code uses Errorf here while the result of parseSymbolReference is ok.

I found this issue when I was using openapi-gen.go to generate the /test/integration/testdata/defaults package (to have a try) and the following error logs appeared.

E0322 16:21:36.249229   11020 openapi.go:707] k8s.io/kube-openapi/test/integration/testdata/defaults.ConstantValue, k8s.io/kube-openapi/test/integration/testdata/defaults
E0322 16:21:36.249997   11020 openapi.go:707] k8s.io/kube-openapi/test/integration/testdata/defaults.ConstantValue, k8s.io/kube-openapi/test/integration/testdata/defaults
E0322 16:21:36.250239   11020 openapi.go:707] k8s.io/kube-openapi/test/integration/testdata/enumtype.FruitApple, k8s.io/kube-openapi/test/integration/testdata/defaults
E0322 16:21:36.250397   11020 openapi.go:707] k8s.io/kube-openapi/test/integration/testdata/enumtype.FruitApple, k8s.io/kube-openapi/test/integration/testdata/defaults
E0322 16:21:36.250527   11020 openapi.go:707] k8s.io/kube-openapi/test/integration/testdata/defaults.ConstantValue, k8s.io/kube-openapi/test/integration/testdata/defaults

But the files were generated successfully.

Hope I don't have any misunderstanding here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot requested review from apelisse and sttts March 22, 2024 09:12
@k8s-ci-robot
Copy link
Contributor

Welcome @caozhuozi!

It looks like this is your first PR to kubernetes/kube-openapi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-openapi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@caozhuozi
Copy link
Contributor Author

cc: @alexzielenski

@caozhuozi caozhuozi changed the title fix log level: error -> info bugfix: change log level from error to info Mar 22, 2024
@Jefftree
Copy link
Member

Thanks for catching this. That makes sense, will leave lgtm to Alex. If anything this seems more like a debug statement that wasn't taken out? Do we need a proper comment rather than just logging id and commentPath?

/approve
/assign @alexzielenski

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caozhuozi, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@caozhuozi
Copy link
Contributor Author

Thanks @Jefftree ! Yes, it looks like a debug statement. Let's see if @alexzielenski could give any suggestions about the logging context.

@alexzielenski
Copy link
Contributor

It likely is a debug statement. I'm ok with it being removed also, Infof seems fine

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit dc4e619 into kubernetes:master Apr 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants