Makefile: Enable experimental Docker CLI #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the docker manifest command is supported see also: https://github.com/kubernetes-sigs/metrics-server/blob/master/Makefile#L15
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
lilic
reviewed
Jul 31, 2020
There was a problem hiding this comment.
/lgtm
Thanks for the quick fix! Let's see what happens, I would prefer if we could find a way to test this before merging cc @serathius do you know of a way to do this as part of the PRs?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
So the
docker manifestcommand is supportedsee also: https://github.com/kubernetes-sigs/metrics-server/blob/master/Makefile#L15
@lilic I had that enabled on my machine, this should resolve the issue for google cloud as well since metrics-server is built on prow and doesn't have additional
gcloudcalls.Follow up from: #1190