-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] check all default collector metrics are available #1616
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
/assign @lilic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but it looks good to me overall.
- Remove usage of deprecated io/ioutil - Comply to PR comments
0d30ebf
to
ce21166
Compare
Awesome, thanks @olivierlemasle. /lgtm |
/assign @mrueg |
/lgtm thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg, olivierlemasle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR supersedes #950, and fixes part of #875.
It is simply a rebase of #950 on
master
, as discussed in #950 (comment).