Implement kube_*_labels and kube_*_annotations metrics for pdb #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces kube_*_labels and kube_*_annotations metrics to poddisruptionbudget to keep in consistency with other k8s objects. Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
|
Hmm, I just realised that there is already a PR from my colleague to achieve the same. |
|
Hi @arajkumar, it looks that that PR is still a draft. Which one of these two should we close? |
1 similar comment
|
Hi @arajkumar, it looks that that PR is still a draft. Which one of these two should we close? |
|
I can close #1620 in favour of this. lgtm |
philipgough
approved these changes
Oct 28, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arajkumar, mrueg, PhilipGough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
2 tasks
arajkumar
added a commit
to arajkumar/kube-state-metrics
that referenced
this pull request
Dec 17, 2021
All other allowlist selectors are using plural form of resource name except PDB. Actually it is a typo introduced by PR[1]. [1] kubernetes#1623 Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit introduces kube_labels and kube_annotations metrics to
poddisruptionbudget to keep in consistency with other k8s objects.
Signed-off-by: Arunprasad Rajkumar arajkuma@redhat.com
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
This change adds 2 new metrics PodDisruptionBudget(PDB) object to get information about labels and annotations.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #