-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingressclass to kube_ingress_info metric #1652
Conversation
Welcome @adammw! |
@dgrisonnet @mrueg do we have any conventions about adding labels to stable metrics? It might break existing rules and queries that use aggregations. |
No official guidelines exist I believe. Since this is an info metric, I'd assume folks extract labels from it and I think the risk of breaking anyones workflow there by adding a new label is low. Also it would be part of a new minor/feature release. |
Thanks Manuel, this makes sense to me. @adammw I noticed that the ingress class label is determined from an annotation value. Is there any reason why you cannot use the [1] https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-class |
Yep, the idea is to fall back to the annotation if the first-class ingressClassName is not used.. |
Ah I missed that part, then this makes sense to me 👍 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adammw, fpetkovski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add ingressclass to kube_ingress_info metric
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Should be same cardinality since it adds a tag to an existing metric that is already one per resource.