Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/store: fix metrics slice length for init containers #1734

Merged
merged 1 commit into from
May 30, 2022
Merged

internal/store: fix metrics slice length for init containers #1734

merged 1 commit into from
May 30, 2022

Conversation

honpey
Copy link
Contributor

@honpey honpey commented May 17, 2022

In #1731 ,
the dynamic slice was introduced to fix potential panic under
Spec.Containers scenario, however there may be same panic for
Spec.InitContainers.

This patch fix it referring to #1731

What this PR does / why we need it:

fix potential panic when there exists disconnect of Spec.InitContainers and Status.InitContainerStatuses

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: honpey / name: honpey (dc0b0a7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 17, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @honpey!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 17, 2022
@honpey
Copy link
Contributor Author

honpey commented May 17, 2022

/cc @jan--f

@k8s-ci-robot
Copy link
Contributor

@honpey: GitHub didn't allow me to request PR reviews from the following users: jan--f.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jan--f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jan--f
jan--f approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

internal/store/pod.go Outdated Show resolved Hide resolved
@fpetkovski
Copy link
Contributor

@honpey would you mind rebasing your branch against master to make the CI pass?

@honpey
internal/store: fix metrics slice length for init containers
9f3e368 
In kubernetes#1731,
the dynamic slice was introduced to fix potential panic under
Spec.Containers scenario, however there may be same panic for
Spec.InitContainers scenario.

This patch fix it referring to kubernetes#1731

Signed-off-by: honpey <honpey@gmail.com>
@mrueg
Copy link
Member

mrueg commented May 30, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honpey, jan--f, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2022
@honpey
Copy link
Contributor Author

honpey commented May 30, 2022

@honpey would you mind rebasing your branch against master to make the CI pass?

done

@k8s-ci-robot k8s-ci-robot merged commit d04c7d1 into kubernetes:master May 30, 2022
@fpetkovski
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f jan--f approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

Assignees

@mrueg mrueg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@honpey @k8s-ci-robot @fpetkovski @mrueg @jan--f