-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom resource metrics documentation #1784
Fix custom resource metrics documentation #1784
Conversation
Welcome @ikarlashov! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one suggestion.
Thanks, this looks good. We also need you to sign the CLA before we merge the PR. |
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
Signed-off-by: Evgen Karlashov <ievgen.karlashov@kpn.com>
f86627e
to
9197bb2
Compare
Hm, that's weird. Because I signed it yesterday. Today I repeated the procedure. But there's still failed check. |
/easycla |
@fpetkovski done :) |
Thanks, /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ikarlashov, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Fixing documentation for custom resource configuration.
How does this change affect the cardinality of KSM: no impact
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): fixes #1782, #1779