Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce custom-resources-only flag ... #1813

Merged
merged 1 commit into from
Nov 8, 2022
Merged

introduce custom-resources-only flag ... #1813

merged 1 commit into from
Nov 8, 2022

Conversation

bavarianbidi
Copy link
Contributor

... to only monitor all known custom-resource configurations instead of
listing each of them explicitly

Signed-off-by: Mario Constanti mario@constanti.de

What this PR does / why we need it:

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1778

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2022
@mrueg
Copy link
Member

mrueg commented Aug 23, 2022

We could add this flag, I'd expect v3.0 to overhaul all the config flags and move us towards an allowlist/denylist model.

@dgrisonnet
Copy link
Member

Agreed, having this flag would be a great addition to ksm.

In v3, we can definitely improve the existing flags to make it easier since the current list kind of grew on us over time, but I wouldn't block that effort on that. It would be great to be able to split ksm and the crd version of ksm already in v2.

mrueg
mrueg reviewed Oct 8, 2022
View reviewed changes
pkg/options/options.go Outdated Show resolved Hide resolved
@mrueg
Copy link
Member

mrueg commented Nov 3, 2022

@bavarianbidi do you have plans to get back to this change? We could try getting it into the next release.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@bavarianbidi bavarianbidi marked this pull request as ready for review November 7, 2022 06:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2022
@bavarianbidi
Copy link
Contributor Author

@bavarianbidi do you have plans to get back to this change? We could try getting it into the next release.

👋 sorry for the late reply 🙈
@mrueg i've rebased the PR and force pushed again.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@bavarianbidi
introduce custom-resources-only flag ...
53af116 
... to only monitor all known custom-resource configurations instead of
listing each of them explicitly

Signed-off-by: Mario Constanti <mario@constanti.de>
mrueg
mrueg approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@mrueg mrueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2022
@dgrisonnet
Copy link
Member

Looking forward to start using this feature, thank you @bavarianbidi :)

/lgtm
/approve
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bavarianbidi, dgrisonnet, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c0a03ad into kubernetes:master Nov 8, 2022
@dgrisonnet dgrisonnet mentioned this pull request Nov 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrueg mrueg mrueg approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@mrueg mrueg

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow monitoring of CRs only
4 participants
@bavarianbidi @mrueg @dgrisonnet @k8s-ci-robot